feat(stdlibs): add package html
#2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2802 +/- ##
=======================================
Coverage 60.95% 60.96%
=======================================
Files 564 564
Lines 75273 75273
=======================================
+ Hits 45885 45887 +2
+ Misses 26018 26017 -1
+ Partials 3370 3369 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Villaquiranm
force-pushed
the
feat/implement-html-package
branch
from
2b7396b
to
ee01d0c
Compare
thehowl
reviewed
Sep 16, 2024
thehowl
reviewed
Sep 16, 2024
moul
approved these changes
Sep 17, 2024
7 tasks
thehowl
changed the title
html
thehowl
pushed a commit
that referenced
this pull request
Oct 2, 2024
<!-- please provide a detailed description of the changes made in this pull request. --> prerequisite of #2802 This pull request ports the files: - replace.go - replace_test.go from the Golang standard library. I added some tags on the code with the hope it will help to review the code and to launch discussion if neccessary. I could after remove these changes ```go // Custom code: XXX_Some_Explanation ( code not present on the original go file) . . . // End of custom code ``` <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details>
Villaquiranm
force-pushed
the
feat/implement-html-package
branch
from
a5f4a1b
to
7b96ed6
Compare
@thehowl rebased :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1267
Maybe we should optimize it ? I did not wanted to do something complex as this is not the main point of this pull request
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description